Skip to content

Move policies index page into index folder

Alexander Turinske requested to merge fix-policies-index-page into master

What does this MR do?

Move policies index page into index folder

  • with !67929 (merged), the policies controller standardized its actions
  • the webpack script started picking up ee/app/assets/javascripts/pages/projects/security/policies/index.js for all the policies actions due to that MR, so I updated the path to the file to be ee/app/assets/javascripts/pages/projects/security/policies/index/index.js
  • I see the <controller_name>/index.js pattern in the code base, but only for paths that have only one action
  • I see the <controller_name>/index/index.js pattern in the code base for controllers with more than one action

Related to #321884 (closed)

Screenshots or Screencasts (strongly suggested)

Page Before After
policies#index Screen_Shot_2021-08-16_at_11.35.11_AM Screen_Shot_2021-08-16_at_11.34.26_AM
policies#new Screen_Shot_2021-08-16_at_11.35.19_AM Screen_Shot_2021-08-16_at_11.34.18_AM

How to setup and validate locally (strongly suggested)

  1. Navigate to a project
  2. Navigate to Deployments => Environments and create an environment
  3. Turn on the :security_policies_orchestration_configuration feature flag
  4. Navigate to Security & Compliance => Policies => New policy

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alexander Turinske

Merge request reports

Loading