Reduce Gitaly calls for keeping around refs of published notes
What does this MR do?
We are currently keeping around commits of each note being published even though they are all the same commits. That results to duplicate ref_exists calls.
For example, if there are 6 draft notes set to be published on a single MR version, there will be around 36 calls for ref_exists.
This fix reduces those calls by getting the unique shas to be kept. Based on local testing, this reduced the ref_exists calls from 36 to 4.
How to setup and validate locally (strongly suggested)
- Create a MR.
- Create multiple draft notes as part of a review on the diff.
- Publish review.
- Check if all the draft notes have been published as comments and shown on the diff properly.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
Related to #226924 (closed)