Fix intermittent 'branch not found' errors when pushing creates an MR
What does this MR do?
When we push to create a merge request (-omr.create), we kick off an asynchronous PostReceive worker job, then synchronously create a merge request. This requires the target branch (but not the source branch) to exist in the repository, so we check when validating the push options.
The PostReceive worker invalidates the branch name cache, but does so asynchronously, so we may race with it. Until it is invalidated, the target branch may appear as if it doesn't exist, so we should instead explicitly invalidate it for ourselves.
This is just dead reckoning at the moment, and is unlikely to solve cases where the target branch is the project's default branch, but it seems worth fixing to me.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #273131 (closed)
Edited by Nick Thomas