Fix stuck bridge jobs when downstream project is invalid
What does this MR do?
This MR fixes stuck bridge jobs when the downstream project is invalid.
We normally try to handle this in Ci::CreateDownstreamPipelineService
but the code doesn't reach there since we make the bridge job stuck in the "pending" state.
In this MR, we don't check the existence of the project in the model. We pass this logic into the worker that already does.
Related to #331703 (closed)
Note: We also have the same problem for "mirroring the status from an upstream pipeline", however, I'll create another MR for that.
Screenshots or Screencasts (strongly suggested)
test:
script: exit 0
deploy:
trigger:
project: my/invalid-project
Before:
After:
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan