Fix instrumentation meta method definition [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Attempt to fix the 500s described in #338893 (closed) which appear on Ruby 3 branch on GDK.
How to setup and validate locally (strongly suggested)
- Revert the fix (or use the master)
- Switch to Ruby3 branch in GitLab:
git checkout sh-test-with-ruby-3.0.0
- Make sure you use Ruby3,
asdf local ruby 3.0.2
;ruby -v
gdk restart rails-web
- You'll receive args-count-related 500 on localhost
- Change anything in the code to trigger hot reload, any puts or comment is enough
- The issue will disappear
- Apply the fix in this branch or switch to it, there won't be an issue after the initial webserver restart
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
N/A
Related to #338893 (closed)
Edited by Aleksei Lipniagov