Add a data migration to remove existing duplicates of DastSiteTokens

What does this MR do?

This merge request adds a data migration to remove the existing duplicates of DastSiteToken with the same URL and project.

The data migration is a regular migration because:

• this is a low traffic feature with 371 rows in the dast_site_tokens table on gitlab.com.
• it should be fast. It currently runs in 1.4s
• To make sure that RemoveDuplicateDastSiteTokens has run before before we run the follow-up MR. The follow-up merge request to this one will be one that adds a unique index.

This MR is responsible for the following tasks required for issue #338188 (closed).

add a data migration to remove existing duplicates add a migration that adds a composite index (project_id, url)

Raw SQL to find the DastSiteToken with duplications:

SELECT DISTINCT
    array_agg(id) AS ids
FROM
    "dast_site_tokens"
GROUP BY
    "dast_site_tokens"."project_id",
    "dast_site_tokens"."url"
HAVING (count(*) > 1)

Time: 0.624 ms

Query Plan

Migration execution time = 1.4s

Migration 20210823132600 up

== 20210823132600 RemoveDuplicateDastSiteTokens: migrating ====================
== 20210823132600 RemoveDuplicateDastSiteTokens: migrated (0.0035s) ===========

Migration 20210823132600 down

== 20210823132600 RemoveDuplicateDastSiteTokens: reverting ====================
== 20210823132600 RemoveDuplicateDastSiteTokens: reverted (0.0000s) ===========

Migration 20210826193907 up

== 20210826193907 AddUniqueIndexDastSiteTokenProjectIdAndUrl: migrating =======
-- transaction_open?()
   -> 0.0000s
-- index_exists?(:dast_site_tokens, [:project_id, :url], {:name=>"index_dast_site_token_on_project_id_and_url", :unique=>true, :algorithm=>:concurrently})
   -> 0.0045s
== 20210826193907 AddUniqueIndexDastSiteTokenProjectIdAndUrl: migrated (0.0051s)

Migration 20210826193907 down

== 20210826193907 AddUniqueIndexDastSiteTokenProjectIdAndUrl: reverting =======
-- transaction_open?()
   -> 0.0000s
-- indexes(:dast_site_tokens)
   -> 0.0024s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- remove_index(:dast_site_tokens, {:algorithm=>:concurrently, :name=>"index_dast_site_token_on_project_id_and_url"})
   -> 0.0033s
-- execute("RESET statement_timeout")
   -> 0.0007s
== 20210826193907 AddUniqueIndexDastSiteTokenProjectIdAndUrl: reverted (0.0085s) 

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
• I have added/updated documentation, or it's not needed. (Is documentation required?)
• I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
• I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
• I have self-reviewed this MR per code review guidelines.
• This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
• I have followed the style guides.
• This change is backwards compatible across updates, or this does not apply.

Availability and Testing

• I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
• I have tested this MR in all supported browsers, or it's not needed.
• I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team