Only set User#commit_email with user input
What does this MR do?
Previously the User profile form automatically set a value for User#commit_email. This would become the database value when the user submitted the form, whether the user was aware of this or not. That behavior was unnecessary, because the User model already assumes the commit_email is the primary email when not set. Further, this behavior complicated validation when the primary email is being changed. As a simple solution, this change introduces a blank option to the select dropdown, which is used by default. Now the database value will only change if the user changes it.
We are doing the same thing for User#notification_email
in !68687 (merged). This is all part of a broader refactoring of User secondary emails.
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Related to #338636
Edited by Dan Jensen