UI for False Positive Identification
Notes
- Behind a feature flag
:vulnerability_flags
. graphQL@include
directive used to feature flag outfalsePositive
field. - Done as a single MR intentionally at the advisement of the team and initial refinement. Turned out to be a more involved than anticipated.
- Adds False positive support to Instance, Group, and Project level dashboards.
- Adds False positive to MR widgets Vulnerability Modal
- Adds false positive to Pipeline Security Tab
What does this MR do?
Project export for running locally
2021-09-06_16-22-863_ssarka_test-false-positive_export.tar.gz
Steps
- Import project
- In CI/CD make sure you have a gitlab runner active for the project
- Run the pipeline on master
- Run the pipeline on the merge request branch in the project
- Add the project to a group, and add it as a project at the instance level
Video Demos
Feature Flag | Video Demo |
---|---|
Off | https://youtu.be/kcAL_NKCwMw |
On | https://youtu.be/Tu3gTa8p4uc |
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #336024
Edited by Taylor McCaslin