Skip to content

Update policy type method to be more robust

Alexander Turinske requested to merge 339142-update-policy-type-method into master

What does this MR do?

Update policy type method to be more robust

  • use GraphQLs __typename field to determine type of policy instead of searching the string
  • update tests

Screenshots or Screencasts (strongly suggested)

No visual changes; I tested all code paths.

Removed all instances of yamlIndicator

How to setup and validate locally (strongly suggested)

  1. Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
  2. Follow the scan execution creation snippet to create some scan execution policies
  3. Turn on the :security_policies_orchestration_configuration feature flag
  4. Navigate to Security & Compliance => Policies
  5. Select different types of policies and try to edit them

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #339142 (closed)

Edited by Alexander Turinske

Merge request reports

Loading