Always show create-jira-issue button on MR-widget modal and pipeline listing when setting is enabled
requested to merge 339173-create-jira-issue-button-does-not-show-on-pipeline-vulnerability-list-and-mr-modal-if-gitlab into master
What does this MR do?
It resolves a bug that prevents the "Creat Jira Issue" button on both the MR-widget and pipeline-security vulnerability listing to appear when jira issues are enabled, but GitLab issues are not.
Screenshots or Screencasts (strongly suggested)
Settings
GitLab-issues settings | Jira-issues settings |
---|---|
Pipeline Vulnerabilities listing
before | after |
---|---|
MR-widget modal
before | after |
---|---|
How to setup and validate locally (strongly suggested)
Prerequisites: Pipeline Setup
- Clone https://gitlab.com/gitlab-examples/security/security-reports/
- Run the pipeline by going into Your project > CI/CD > Pipelines
- Click on run pipeline for master branch
- Go to Project > CI/CD > Pipelines > Your Pipeline > Security Tab
You should have the runner installed in order to run the pipeline. Then using the following command you can register the runner, it guides you pretty good on how to set the runner:
$ gitlab-runner register
Once it's installed this is how I run the runner:
$ gitlab-runner --log-level debug run local-runner --config ~/.gitlab-runner/config.toml restart
Fix validation
- Enable the Jira Integration for a project.
- Enable the option "Enable Jira issues creation from vulnerabilities" for the project.
- Create a merge request with some vulnerabilities detected by one of the scanner.
- Make sure the "Gitlab Issues" functionality is enabled.
- Open the the pipeline's security tab and check the vulnerability listing's action buttons / Click on one of the vulnerabilities in the MR widget
- Notice the create "Jira issue button" is present.
- Disable the GitLab Issues functionality for the project.
- Open the MR and click on one of the vulnerabilities.
- Notice the create "Jira issue button" is not longer present.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #339173 (closed)
Edited by David Pisek