Fix disappearing badge in commit image thread edit
What does this MR do?
When the user is editing a comment of an image thread on the commit page, the badge disappears when the user saves the comment.
Initial | After Edit | Refresh |
---|---|---|
In this MR, we fix this by forcing a page refresh when the edit comment is saved.
🍄
Note Yes, this solution is not ideal but as pointed out here:
Given the rarity of this occurrence (commit comments are rare, image comments are even rarer), I'd be ok in finding a very simple fix, even if forcing a reload of the page.
The code is not shared with MR Diffs and these pages are set to be rewritten into Vue anyway, so not worth putting a lot of effort into it.
Testing case
- Navigate to a commit page that contains an image.
- Make a comment on the image by clicking on the image and save that comment.
- Edit that previously said comment.
-
the page will refresh and the badge on the avatar remains.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #19804 (closed)