Switching from Faker to SecureRandom
What does this MR do?
Addressing issue with Ruby 2.7 warning that failed E2E tests #339101 (closed) with error
Failure/Error: example.run_with_retry retry: retry_times
DeprecationToolkit::Behaviors::DeprecationIntroduced:
You have introduced new deprecations in the codebase. Fix or record them in order to discard this error.
You can record deprecations by adding the `DEPRECATION_BEHAVIOR='record'` ENV when running your specs.
DEPRECATION WARNING: /usr/local/bundle/gems/faker-1.9.3/lib/faker.rb:155: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/usr/local/bundle/gems/i18n-1.8.10/lib/i18n.rb:196: warning: The called method `translate' is defined here
SecureRandom
seems to be a good alternative so I'm switching over to use this instead of Faker::
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Related to #339101 (closed)
Edited by Tiffany Rea