Skip to content

Bump prometheus-client-mmap to 14.0 [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Aleksei Lipniagov requested to merge 339001-bump-prom-mmap-gem into master

What does this MR do?

The primary goal is to resolve #339001 (closed) - drop noisy warning polluting the output on Ruby 3 branch. It was fixed in https://gitlab.com/gitlab-org/prometheus-client-mmap/-/merge_requests/59 and included in 14.0 version of the gem.

Changelog:

v0.14.0
Remove deprecated taint mechanism logic

v0.13.0
Gauge: add decrement method to gauge metric type !57
Update push.rb to use newest client_ruby code !56994

How to setup and validate locally (strongly suggested)

  1. Check: metrics are being collected when running on this branch
  2. Additionally, when running with Ruby 3 (including specs), you should no longer see the warning: lib/prometheus/client/helper/entry_parser.rb:16: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2. You will see them on older version of the gem, e.g. 0.13. Note: similar warning would still be appear coming fast-gettext, we are trying to resolve it upstream.

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

N/A

Related to #339001 (closed)

Edited by Aleksei Lipniagov

Merge request reports

Loading