Skip to content

Fix MR review bar hiding part of the right sidebar

Tomas Vik requested to merge 327890-review-bar-hides-sidebar into master

What does this MR do?

This MR fixes an issue where the MR review bar might be hiding part of the right sidebar. This MR uses a class added on the body element (similarly to how performance and system headers do it). The reason for using class on the body is because the sidebar and the diffs apps are different Vue apps.

We've done similar work for the MR changed files tree !59150 (merged)

Screenshots or Screencasts (strongly suggested)

before after
revew-bar-hides-sidebar Can_be_automatically_merged___8____Merge_requests___Gitlab_Org___Gitlab_Test___GitLab

How to setup and validate locally (strongly suggested)

  1. Open any merge request and go to the "Changes" tab.
  2. Create a new review comment on the diff ("start review" button, not the "add comment now")
  3. you should now see the review bar at the bottom of the screen
  4. make sure the window height is less than 780px (you can use responsive design tools in your browser)
  5. you should see both copy buttons at the bottom of the right sidebar, not just one (see screencast above to see what bug to look for)

-->

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #327890 (closed)

Edited by Tomas Vik

Merge request reports

Loading