Skip to content

Skip highlighting cache for diffs with unsupported characters

What does this MR do?

Contributes to #207124 (closed)

Sentry error: https://sentry.gitlab.net/gitlab/gitlabcom/issues/2770092

Problem

500 error when diff contains unsupported characters that we cannot save in Redis

Solution

Skip a highlighting cache generation for affected diff files. It doesn't fully resolves the problem but it improves the user experience. They can access the diff page again.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vasilii Iakliushin

Merge request reports

Loading