Prevent overriding DOMPurify's default config with custom configuration
What does this MR do?
This MR updates the logic for handling DOMPurify configurations in a way that it always include the default configuration.
Why
With the current implementation, if a configuration is passed to DOMPurify's sanitize fn, it overrides the default config. The default config exists to add defense-in-depth by default, and the existing behavior could lead to cross-site scripting bugs.
Similar implementation can be found for v-safe-html
Screenshots or Screencasts (strongly suggested).
No visual changes for user
Follow-up Improvements
https://gitlab.com/gitlab-org/gitlab/-/issues/339708
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi