Display correct action buttons when viewing non-text files
What does this MR do?
Displays the correct action buttons when viewing an image
Screenshots or Screencasts (strongly suggested)
before | after |
---|---|
How to setup and validate locally (strongly suggested)
This feature is behind the :refactor_blob_viewer
feature flag.
- run
rails c
in the project root - run
Feature.enable(:refactor_blob_viewer)
in the rails console - upload an image to a repository
- view the image
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #324330 (closed)
Edited by Jacques Erasmus