Add policy name to ScanExecutionPolicyCommit mutation
What does this MR do?
Addresses #339794 (closed)
This MR adds a new argument name
to ScanExecutionPolicyCommit mutation. Since we do not have a reference to a policy in the yaml file in policy project, the name of the policy is considered as an unique identifier. But if the name of the policy need to be updated, the old name has to mentioned explicitly to make it work.
Screenshots or Screencasts (strongly suggested)
Before | After |
---|---|
Different name while creating policy:
Mutation
mutation createPolicy{
scanExecutionPolicyCommit(input:{
projectPath:"root/rails-demo",
operationMode:REPLACE,
name: Policy
policyYaml: "name: Updated Policy\ntype: scan_execution_policy\ndescription: This policy enforces pipeline configuration to have a job with secret detection scan\nenabled: true\nrules:\n- type: pipeline\n branches: \n - master\nactions:\n- scan: secret_detection"
}) {
clientMutationId
branch
errors
}
}
Response
{
"data": {
"scanExecutionPolicyCommit": {
"clientMutationId": null,
"branch": "update-policy-1624288106",
"errors": []
}
}
}
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alexander Turinske