Change order of sidekiq LoadBalancing middleware
What does this MR do?
We decided to split !66280 (comment 650854524).
In order to add support for idempotent jobs for workers that are using load balancing capabilities, we need to change order how our sidekiq server and client middleware are loaded.
-
:Gitlab::Database::LoadBalancing::SidekiqClientMiddleware
should be placed before::Gitlab::SidekiqMiddleware::DuplicateJobs::Client
middleware, so we can store WAL location in job hash before we deduplicate the job. -
::Gitlab::SidekiqMiddleware::DuplicateJobs::Server
should be placed at the bottom, but before the::Gitlab::Database::LoadBalancing::SidekiqServerMiddleware
, this way, when we add support for deduplication, if job's wal location is updated by deduplication strategy, we can compare that updated location inSidekiqServerMiddleware
.
Note: This MR just changes middleware order, and this is just a preparation work for #325291 (closed).
We can easily roll back if there are some negative consequences.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325291 (closed)