Skip to content

Resolve "Markers, ticks and labels in SVG images in Jupyter notebooks are not rendered"

What does this MR do?

SVGs tags on the form of <use xlink:href='#some-element' /> were being removed for not conforming to a safe url, even if they were referencing internal elements.

Screenshots or Screencasts (strongly suggested)

Before After
image image

How to setup and validate locally (strongly suggested)

  1. Clone https://gitlab.com/gitlab-org/incubation-engineering/mlops/ipynb-test-projects/svg-jupyter-test
  2. Open svg-test.ipynb
  3. The numbers in the axis should appear

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332273 (moved)

Edited by Eduardo Bonet

Merge request reports

Loading