Skip to content

Avoid repeat creation of deactivated user

Serena Fang requested to merge move-deactivate-user-creation-higher into master

What does this MR do?

Reuse the deactivated_user object created here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/requests/api/users_spec.rb#L15, rather than creating a new deactivated_user or user.deactivate.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Serena Fang

Merge request reports

Loading