Skip to content

EE port for 29398 support kubernetes rbac for gitlab managed apps

CE MR at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21127

What does this MR do?

EE port for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21127

  • Implement rbac? for UpgradeCommand which is now required by BaseCommand
  • Update a concern used by both KubernetesService and Clusters::Platforms::Kubernetes to use build_kube_client! as build_kubeclient! no longer exists

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/29398

Does this MR meet the acceptance criteria?

Manual QA

  • Check that UpgradeCommand works in a RBAC cluster
  • Check that UpgradeCommand works in a ABAC cluster
    • provision a new cluster with GitLab on master
    • install prometheus
    • switch to this branch, restart GDK
    • trigger UpgradeCommand by setting up an alert on a custom metric

To trigger UpgradeCommand, use the steps from https://gitlab.com/gitlab-org/gitlab-ce/issues/47154#note_92205407, then check the cluster on GKE

Edited by Thong Kuah

Merge request reports

Loading