Mark feature flags in Gitlab/MarkUsedFeatureFlags only once
What does this MR do?
Mark dynamic feature flags and feature flags for usage data counters only once per whole rubocop run instead of once per file.
This reduces the overall runtime of this cop drastically:
time bundle exec rubocop -C false -f q --only Gitlab/MarkUsedFeatureFlags
- Before: ~8m53.589s
- After: ~3m56.036s
For cached runs (rubocop --cache true
- the default) Gitlab/MarkUsedFeatureFlags
does not track feature flags at all because this cop is skipped. tmp/feature_flags
remains empty. On CI, however, we are disabling caching for this specific cop.
Screenshots or Screencasts (strongly suggested)
n/a
How to setup and validate locally (strongly suggested)
Run:
time bundle exec rubocop -C false --only Gitlab/MarkUsedFeatureFlags
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. - [-] This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen