[4/5] Add unauthenticated API throttle settings to admin area
What does this MR do?
This adds the new settings to the "User and IP Rate Limits" section in the admin area, and also updates the styling a bit.
Issue: #335300 (closed)
Roadmap
- Rename attributes for unauthenticated rate limit: !69543 (merged)
- Add columns for unauthenticated API rate limit: !69384 (merged)
- Apply unauthenticated API rate limit in Rack Attack configuration: !69388 (merged)
-
Update settings form in admin area:
👈 This MR - Documentation update: !69487 (merged)
Screenshots or Screencasts (strongly suggested)
Besides adding the new settings, this also updates the styling a bit based on the suggestions made in the similar MR !68560 (merged):
Old style | New style |
---|---|
- Use GitLab UI checkboxes.
- Add
fieldset
around each rate limit. - Remove
hr
between sections.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #335300 (closed)
Edited by Markus Koller