Skip to content

Pull Zuora plan ID from CustomersDot API

What does this MR do?

Replaces a hard-coded Zuora plan id with a value retrieved from the CustomersDot application instead.

  • Creates a TrialStatusWidgetHelper#ultimate_plan_id method to fetch the Ultimate plan id
  • Creates a PaidFeatureCalloutHelper#premium_plan_id method to fetch the Premium plan id
  • Uses the GitlabSubscription::FetchSubscriptionPlansService for each of those new methods

Note: The PaidFeatureCalloutHelper is part of an experiment which is currently unreachable (#273627 (comment 674150108)) but is yet to be cleaned up. It is likely that the code for it will be entirely removed. If not, there is already an issue in place to extract the commonalities between these two helpers (#340441 (closed)), including reusing the FetchSubscriptionPlansService data: !70009 (diffs)

How to setup and validate locally (strongly suggested)

  1. Enable trials
  2. Start a trial
  3. On the trial status widget, click on the “Upgrade” button
  4. The “Ultimate” plan should be pre-selected

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #330987 (closed)

Edited by Mayra Cabrera

Merge request reports

Loading