Skip to content

Fix flaky test on pipeline metrics

Albert requested to merge alberts-fix-memoize-nil-in-spec into master

What does this MR do?

Fix flaky test as a result of a memoized nil value. #340022 (closed)

How to setup and validate locally (strongly suggested)

Run bundle exec rspec spec/lib/gitlab/ci/pipeline/metrics_spec.rb spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb.

Before: spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb fails After: spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb passes

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Albert

Merge request reports

Loading