Skip to content

Lower max relation pagination count with feature flag

Sean Arnold requested to merge sarnold-lower-max-relation-pagination-count into master

What does this MR do?

As part of the investigation into https://gitlab.com/gitlab-org/gitlab/-/issues/331565 we found that counts are still relatively slow even with the 10_000 limit we have to count total number of rows.

This was originally introduced in gitlab-foss!23931 (merged).

This MR reduces that limit to 1_000.

This is behind an Ops FF, lower_relation_max_count_limit.

How will we measure succes?

The following Kibana visualisations show max/avg DB timings for 2 endpoints we investigated in https://gitlab.com/gitlab-org/gitlab/-/issues/331565

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sean Arnold

Merge request reports

Loading