Skip to content

Resolve "Address the Primary Key Overflow risk for the ci_build_trace_chunks table - Step 3: Drop temporary columns and triggers"

What does this MR do?

This MR removes the column build_id_convert_to_bigint and the trigger trigger_cf2f9e35f002 from the ci_build_trace_chunks table.

migration up:

== 20210906100316 DropTemporaryColumnsAndTriggersForCiBuildTraceChunks: migrating
-- remove_column("ci_build_trace_chunks", "build_id_convert_to_bigint")
   -> 0.0012s
== 20210906100316 DropTemporaryColumnsAndTriggersForCiBuildTraceChunks: migrated (0.0220s)

migration down:

== 20210906100316 DropTemporaryColumnsAndTriggersForCiBuildTraceChunks: reverting
-- table_exists?("ci_build_trace_chunks")
   -> 0.0005s
-- column_exists?("ci_build_trace_chunks", :id)
   -> 0.0014s
-- column_exists?("ci_build_trace_chunks", "build_id")
   -> 0.0008s
-- columns("ci_build_trace_chunks")
   -> 0.0011s
-- add_column("ci_build_trace_chunks", "build_id_convert_to_bigint", :int, {:default=>0, :null=>false})
   -> 0.0023s
== 20210906100316 DropTemporaryColumnsAndTriggersForCiBuildTraceChunks: reverted (0.0418s)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338069 (closed)

Edited by Diogo Frazão

Merge request reports

Loading