Skip to content

Disable method instrumentation initialization [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

We are deprecating the method instrumentation the way we implemented it, as we are not using the data produced by the instrumented classes and methods while the approach itself:

  • redefines every method with metaprogramming/monkey patching
  • makes some assumptions on the method arity which is tricky to test and may be prone to errors
  • appears almost on every trace, so it could mask the real issue with the argument mismatch
  • does something that the profiler should do, but with the custom solution
  • adds performance & memory penalty to our call chain

The implementation code would be removed in the next MR(s) to ship smaller changes (as this touches the initializers).

More context at: #217978 (closed)

FF issue: #339665 (closed)

Next steps:

  • Remove the implementation
  • Clean up the docs

How to setup and validate locally (strongly suggested)

It's a FF change that is tested on all envs at that moment, so nothing specific.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

N/A

Related to #339665 (closed)

Edited by Aleksei Lipniagov

Merge request reports

Loading