Disable method instrumentation initialization [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
We are deprecating the method instrumentation the way we implemented it, as we are not using the data produced by the instrumented classes and methods while the approach itself:
- redefines every method with metaprogramming/monkey patching
- makes some assumptions on the method arity which is tricky to test and may be prone to errors
- appears almost on every trace, so it could mask the real issue with the argument mismatch
- does something that the profiler should do, but with the custom solution
- adds performance & memory penalty to our call chain
The implementation code would be removed in the next MR(s) to ship smaller changes (as this touches the initializers).
More context at: #217978 (closed)
FF issue: #339665 (closed)
Next steps:
- Remove the implementation
- Clean up the docs
How to setup and validate locally (strongly suggested)
It's a FF change that is tested on all envs at that moment, so nothing specific.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
N/A
Related to #339665 (closed)
Edited by Aleksei Lipniagov