Skip to content

Cleanup bigint conversion for ci_builds_metadata

What does this MR do?

This MR removes columns and triggers used for the bigint conversion of table ci_builds_metadata.

  • remove column id_convert_to_bigint
  • remove column build_id_convert_to_bigint
  • remove trigger_542d6c2ad72e trigger and function
  • remove trigger_8487d4de3e7b trigger and function

Related to #338070 (closed).

Database migrations

Up

$ bundle exec rails db:migrate:up VERSION=20210907013944
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: migrating =======
-- remove_column(:ci_builds_metadata, "id_convert_to_bigint")
   -> 0.0008s
-- remove_column(:ci_builds_metadata, "build_id_convert_to_bigint")
   -> 0.0007s
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: migrated (0.0209s)

Down

$ bundle exec rails db:migrate:down VERSION=20210907013944
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: reverting =======
-- table_exists?(:ci_builds_metadata)
   -> 0.0005s
-- column_exists?(:ci_builds_metadata, :id)
   -> 0.0012s
-- column_exists?(:ci_builds_metadata, :build_id)
   -> 0.0009s
-- columns(:ci_builds_metadata)
   -> 0.0013s
-- add_column(:ci_builds_metadata, "build_id_convert_to_bigint", :int, {:default=>0, :null=>false})
   -> 0.0021s
-- table_exists?(:ci_builds_metadata)
   -> 0.0004s
-- column_exists?(:ci_builds_metadata, :id)
   -> 0.0012s
-- column_exists?(:ci_builds_metadata, :id)
   -> 0.0011s
-- columns(:ci_builds_metadata)
   -> 0.0011s
-- add_column(:ci_builds_metadata, "id_convert_to_bigint", :int, {:default=>0, :null=>false})
   -> 0.0011s
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: reverted (0.0432s) 

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338070 (closed)

Edited by Krasimir Angelov

Merge request reports

Loading