Cleanup bigint conversion for ci_builds_metadata
What does this MR do?
-
Merge only after !65692 (merged) is deployed to production
This MR removes columns and triggers used for the bigint
conversion of table ci_builds_metadata
.
- remove column
id_convert_to_bigint
- remove column
build_id_convert_to_bigint
- remove
trigger_542d6c2ad72e
trigger and function - remove
trigger_8487d4de3e7b
trigger and function
Related to #338070 (closed).
Database migrations
Up
$ bundle exec rails db:migrate:up VERSION=20210907013944
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: migrating =======
-- remove_column(:ci_builds_metadata, "id_convert_to_bigint")
-> 0.0008s
-- remove_column(:ci_builds_metadata, "build_id_convert_to_bigint")
-> 0.0007s
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: migrated (0.0209s)
Down
$ bundle exec rails db:migrate:down VERSION=20210907013944
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: reverting =======
-- table_exists?(:ci_builds_metadata)
-> 0.0005s
-- column_exists?(:ci_builds_metadata, :id)
-> 0.0012s
-- column_exists?(:ci_builds_metadata, :build_id)
-> 0.0009s
-- columns(:ci_builds_metadata)
-> 0.0013s
-- add_column(:ci_builds_metadata, "build_id_convert_to_bigint", :int, {:default=>0, :null=>false})
-> 0.0021s
-- table_exists?(:ci_builds_metadata)
-> 0.0004s
-- column_exists?(:ci_builds_metadata, :id)
-> 0.0012s
-- column_exists?(:ci_builds_metadata, :id)
-> 0.0011s
-- columns(:ci_builds_metadata)
-> 0.0011s
-- add_column(:ci_builds_metadata, "id_convert_to_bigint", :int, {:default=>0, :null=>false})
-> 0.0011s
== 20210907013944 CleanupBigintConversionForCiBuildsMetadata: reverted (0.0432s)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #338070 (closed)
Edited by Krasimir Angelov