Remove the feature flag packages_nuget_new_package_file_updater
🖲 Context
When NuGet packages are uploaded to the GitLab Package Registry, those packages need to be processed by a background job before they are available for pulling.
That job might need to update the package name and version. That update will induce a move of the package file in object storage. Basically, the key used by object storage needs to be updated.
In !66728 (merged), we fixed a pretty nasty ~bug that happened with large NuGet packages. What happened is that CarrierWave is not properly suited to "move" a file in object storage. What would happen is that the file is downloaded from object storage to re-uploaded to object storage under the new key. This is highly inefficient. In !66728 (merged), we manually moved the file in object storage to avoid those not so useful downloads/uploads to object storage.
For all the technical details, see !66728 (merged).
That fix was deployed using a feature flag that was then changed to be enabled by default. That was in %14.2. See the rollout issue: #336511 (closed).
We are now at the step of code cleanup where we remove the feature flag.
🔎 What does this MR do?
- Remove the
packages_nuget_new_package_file_updaterfeature flag - Update the related service
- Update the related spec
🖼 Screenshots or Screencasts (strongly suggested)
n / a
⚗ How to setup and validate locally (strongly suggested)
See !66728 (merged)
🚓 Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #336511 (closed)