Skip to content

Dark text for light color labels in dark mode

Simon Knox requested to merge psi-label-dark-text into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Make text black again on light background labels.

Fix for gitlab-ui#1545 (closed) - I would prefer we eventually handle the text colors within gitlab UI, but for now I used the same approach that was done for light text in labels.

Screenshots or screen recordings

before after
Screen_Shot_2021-09-16_at_11.20.50_am Screen_Shot_2021-09-16_at_11.21.06_am

How to set up and validate locally

  1. Enable dark mode
  2. View a light colored label
  3. Text should be black

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading