Skip to content

Add additional properties to policy_details helper

Alexander Turinske requested to merge fix-policy-editor-with-security-orchestration-ff-off into master

What does this MR do and why?

Add additional properties to policy_details helper

  • for the :security_orchestration_policies_configuration feature flag, we started using the orchestration_policy_data helper method for policies, but used the same frontend that the policy_details helper provides for
  • some properties were added for the orchestration_policy_data helper that were not added to the policy_details helper
  • after the :security_orchestration_policies_configuration feature flag is removed (probably in %14.4 ), this helper will be deleted
  • update test

Changelog: fixed EE: true

How to set up and validate locally

  1. Disable the :security_orchestration_policies_configuraion feature flag 
    Feature.enable(:security_orchestration_policies_configuraion)
  2. Visit any project
  3. Navigate to Security & Compliance => Threat Monitoring => Policies tab => New policy

Screenshots or screen recordings

Page Before After
Policy Editor - w/out environment - ff off before-editor after-no_env
Policy Editor - w/ environment - ff off before-editor after-env
Policy Editor - ff on ff-on No visual change

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alexander Turinske

Merge request reports