Skip to content

Stop searching for externalized Vue templates in HAML

Lukas Eipert requested to merge leipert-remove-vue-in-haml-extrapolation into master

What does this MR do and why?

Stop searching for externalized Vue templates in HAML

With gitlab-foss!10669 (merged) we introduced parsing and extracting and externalized strings in Vue templates in HAML.

We have recently stopped writing Vue templates inside of HAML for performance reasons and due to security concerns:

Therefore we can stop searching for them in HAML files.

Screenshots or screen recordings

N/A

How to set up and validate locally

No need if the pipeline passes 😉 If there still were any externalized strings hidden as Vue templates in HAML, static analysis would catch it. But if you really want to, you can run: bundle exec rake gettext:regenerate

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports