Update compliance report drawer to share code with threat monitoring
requested to merge 334780-follow-up-from-add-the-initial-drawer-to-the-compliance-dashboard into master
What does this MR do and why?
This MR refactor the compliance report drawer to:
- Use threat monitoring's
getContentWrapperHeight
utility method - Create a shared
DRAWER_Z_INDEX
constant for both compliance & monitor drawers
Issue: #334780 (closed)
Screenshots or screen recordings
No visual changes.
Compliance report
Before | After |
---|---|
Threat monitoring
Only change is the DRAWER_Z_INDEX
constant being imported.
How to set up and validate locally
Compliance report
- You need a GitLab Ultimate license.
- Go to
[HOST]/groups/[GROUP]/-/security/compliance_dashboard
. - Check that MR's are shown, if they aren't then you may need to merge some in the group.
- Check the MR's data appears and only the individual links are clickable.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #334780 (closed)
Edited by Jiaan Louw