Skip to content

Adds specs to the cross database allowlist

Gary Holtz requested to merge garyh-patch-diff-controller-specs into master

What does this MR do and why?

Running the specs at ./spec/controllers/projects/merge_requests/diffs_controller_spec.rb will produce the following error with the latest master branch:

      Failure/Error:                                                               
        raise Database::PreventCrossDatabaseModification::CrossDatabaseModification
AcrossUnsupportedTablesError,                                                      
          "Cross-database data modification of '#{schemas.to_a.join(", ")}' were de
tected within " \                                                                  
          "a transaction modifying the '#{all_tables.to_a.join(", ")}' tables"     
                                                                                   
      Database::PreventCrossDatabaseModification::CrossDatabaseModificationAcrossUn
supportedTablesError:                                                              
        Cross-database data modification of 'gitlab_main, undefined' were detected 
within a transaction modifying the 'users, namespaces, routes' tables

This adds the diff controller to the allow list so specs can run again!

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Gary Holtz

Merge request reports