Skip to content

Make use of the project data served by Rails

Denys Mishunov requested to merge 281686-use-proj-data into master

What does this MR do and why?

This is the second attempt to address #281686 (closed).

The original MR: !55808 (closed)

This MR contains all the feedback gathered in the original MR plus additional improvements/fixes

Screenshots or screen recordings

This is an MR improving performance of WebIDE. In all "After" measurements note Duration 0 for WebIDE: Project data measurement. This means that there was no time spent on the client to fetch the project data. The reason why it's not 0 when opening an MR is that the start mark for this measurement is fired right away, but the finish one will be triggered only after we request to open the very first changed file of the MR. Nevertheless, no project data request is sent when opening an MR.

Opening a project

Look

Before After
master-empty new-empty

Performance metrics

Before After
Screenshot_2021-10-28_at_01.19.53 Screenshot_2021-10-28_at_01.20.00

Opening a file

Look

Before After
master-file new-file

Performance metrics

Before After
Screenshot_2021-10-28_at_01.22.03 Screenshot_2021-10-28_at_01.22.08

Opening an MR

Look

Before After
master-mr new-mr

Performance metrics

The reason why the Duration of WebIDE: Project data measurement is not 0 here is that the start mark for this measurement is fired right away, but the finish one will be triggered only after we request to open the very first changed file of the MR. Nevertheless, no project data request is sent when opening an MR.

Before After
Screenshot_2021-10-28_at_01.48.44 Screenshot_2021-10-28_at_01.48.07

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #281686 (closed)

Edited by Denys Mishunov

Merge request reports

Loading