Skip to content

test: Set Gitaly's bundle path as absolute path

Toon Claes requested to merge toon-gitaly-bundler-fix into master

What does this MR do and why?

Tests depend on Gitaly running in the background. There are a few scripts and libraries that take care of setting up and spawning Gitaly. These instructions run from different locations in the project source tree. Because some people might be specifying the BUNDLE_PATH as a relative location (i.e. vendor/bundle), the setup step might install gems in a different location from where Gitaly-ruby expects when it's being spawned.

To overcome this, the BUNDLE_PATH is read from the Bundler configuration and expanded to an absolute path before it's passed on to Gitaly setup/spawn.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports