Migrate historical_max_users metric to Instrumentation class
What does this MR do and why?
Related to #338461 (closed)
Migrate historical_max_users
EE metric to Instrumentation class.
How to set up and validate locally
Covered by an unit test https://gitlab.com/gitlab-org/gitlab/blob/f272c7dd5ea10394c4d2dd2f90a249dd35964632/ee/spec/lib/ee/gitlab/usage_data_spec.rb#L205-205
To test manually:
-
Gitlab::UsageDataNonSqlMetrics.uncached_data['historical_max_users']
for usage data -
ServicePing::SubmitService.new.execute
then check atRawUsageData.last.payload['historical_max_users']
for service ping
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #338461 (closed)
Edited by Niko Belokolodov