Disallow review-qa-smoke job to fail in Frontend and QA MRs
What does this MR do and why?
Describe in detail what your merge request does and why.
Disallows review-qa-smoke
job to fail in MRs with Frontend and QA changes. At the moment review-qa-smoke
job is allowed to fail and its status is being ignored - so the smoke tests failures are not being addressed and end up blocking deployments down the line.
The current success rate of the job is at about 93% with the remaining failures being caused either by MR changes (exactly what we are trying to catch early on) or by Review App deploy failures (will be mitigated with !61655 (merged)).
See gitlab-com/www-gitlab-com#12270 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.