Skip to content

Allow various runner scopes that issues cross-db query

Thong Kuah requested to merge allowlist_runner_callsites into master

What does this MR do and why?

Allow various runner scopes that issues cross-db query

This should handle this list of callsites (a few hundred calls in CI):

 480 spec/requests/api/ci/runners_spec.rb 
  40 /builds/gitlab-org/gitlab/app/controllers/admin/runners_controller.rb:89:in `assign_builds_and_projects'
  20 /builds/gitlab-org/gitlab/app/models/ci/runner.rb:429:in `assignable_for?'
   4 /builds/gitlab-org/gitlab/lib/api/ci/runners.rb:175:in `block (2 levels) in <class:Runners>'

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports