Skip to content

Add custom label GitHub status check checkbox

What does this MR do and why?

Related to #326339 (closed).

This MR adds a checkbox_label property to integrations, and supports this in app/assets/javascripts/integrations/edit/components/dynamic_field.vue. This allows us to specify a label for the checkbox itself, in addition to a label for the form group.

As a result, we fix the issue raised in #326339 (closed) where (Optional) was repeated twice in a checkbox field in the GitHub integration.

Screenshots or screen recordings

Before After
Screen_Shot_2021-10-19_at_12.10.09_pm Screen_Shot_2021-10-19_at_12.09.36_pm

How to set up and validate locally

  1. Create project (or, navigate to an existing project)
  2. Navigate to the GitHub Integration form for the project (Settings > Integrations > GitHub)
  3. Observe the checkbox.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tom Quirk

Merge request reports

Loading