Skip to content

Ignore plans and gitlab_subscriptions in cross modification check

What does this MR do and why?

Read more at #343394 (closed) .

We are regularly seeing CrossDatabaseModificationAcrossUnsupportedTablesError failures when we call Plan.default and/or Namespace#actual_plan because both of these methods are lazily creating records.

At present we believe this is not strictly a problem that we need to solve since it will is likely totally OK that creating a plans record in the middle of a transaction related to ci_pipelines is not important to rollback. Even more these lazy creations likely never need to be rolled back anyway so we probably don't need to push these outside the transactions.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #343394 (closed)

Edited by Adam Hegyi

Merge request reports

Loading