Skip to content

Add Sidekiq size limiter defaults to fake settings

Heinrich Lee Yu requested to merge fix-background-migrations-failures into master

What does this MR do and why?

Fixes migration specs that are failing on master.

Sample failure: https://gitlab.com/gitlab-org/gitlab/-/jobs/1696547657

In !72510 (merged) we removed the fallback values because we are now reading from application settings which is validated and has default values from the DB. But this is not the case when using FakeApplicationSettings and the DB entry is not present.

How to set up and validate locally

  1. bin/rspec ./ee/spec/lib/ee/gitlab/background_migration/migrate_devops_segments_to_groups_spec.rb:64

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports