Skip to content

Dequarantine and fix licence spec pipeline test

Will Meek requested to merge licence_compliance_spec_deq into master

What does this MR do and why?

Describe in detail what your merge request does and why.

As per #285120 (closed) this test was originally quarantined as failing on Master due to the SPDX table not initially populating.

This test de-quarantines the test for persistent environments (Production, Pre, Staging).

A further future iteration of this test will apply to fresh omnibus instances (Master, Nightly) to test any messaging relating to the table when #341615 (closed) has been implemented

In the time that this test was quarantined, it got into a failing state in Quarantine jobs due to test syntax, this MR also fixes the test functionally.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Test against local instance (Should skip as pending) CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://instance-address/ ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb

Test against staging (Should not skip) <Staging env variables> CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All https://staging.gitlab.com ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb

Test result against Staging


Top 4 slowest examples (45.99 seconds, 58.0% of total time):
  Secure License Compliance License Management Pipeline Licence tab can approve and deny licenses in the pipeline
    17.94 seconds ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb:86
  Secure License Compliance License Management can approve a license in the settings page
    12.31 seconds ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb:71
  Secure License Compliance has empty state
    11.9 seconds ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb:17
  Secure License Compliance License Management can deny a license in the settings page
    3.85 seconds ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb:78

Finished in 1 minute 19.34 seconds (files took 15.18 seconds to load)
4 examples, 0 failures

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Will Meek

Merge request reports