Skip to content

Improvements to integration_settings_form_spec.js

Tom Quirk requested to merge tomquirk/342463-final-improve-integration-settings-form-spec into master

What does this MR do and why?

Related to #342463 (closed). This MR aims to improve integration_seetings_form_spec.js in coverage and readability. Specifically, this MR makes the following changes:

  • Moves toast/error messages to constants file.
  • Test event handling rather than unit-testing class methods.
  • Add missing coverage for the following events:
    • SAVE_INTEGRATION_EVENT
    • TEST_INTEGRATION_EVENT
  • Limit nested beforeEach for readability/maintainability

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tom Quirk

Merge request reports