Skip to content

Update workhorse's zipartifacts to work with Go 1.17

Arran Walker requested to merge 340778-fix-go17-zip-range-requests into master

What does this MR do and why?

Due to a change in Go's archive/zip library, workhorse was no longer suitable to be built with Go 1.17 as its artifact metadata handling would produce more HTTP requests than anticipated: #340778 (closed)

In !70443 (merged), we introduced a test for the regression, but had to skip it for Go 1.17 so that the pipeline would pass and the MR merged.

This MR fixes the problem, by using a forked version of archive/zip (https://gitlab.com/gitlab-org/golang-archive-zip/) without the problematic change, and removes skipping the test so any future issue will be found.

The fix for archive/zip has been merged upstream (https://go-review.googlesource.com/c/go/+/357489) but won't be available until go1.18.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #340778 (closed)

Edited by Arran Walker

Merge request reports

Loading