Skip to content

Implement the All on-demand DAST scans tab

Paul Gascou-Vaillancourt requested to merge 341364-dast-view-scans-all-tab into master

What does this MR do and why?

This implements the main logic for the All tab in the on-demand scans index page:

  • Polls for pipelines from the source ondemand_dast_scan.
  • Presents the results in a paginated list.
  • The pagination is synced with the route.

What doesn't this MR do and why?

This MR doesn't...

  • ...handle potential network/API errors when fetching pipelines.
  • ...implement a loading state to be shown while pipelines are being fetched.

These have been left out of this MR to make the changeset smaller and more manageable for reviewers. Both this points will be addressed in a follow-up MR.

Screenshots or screen recordings

List

Desktop Mobile

Pagination

How to set up and validate locally

  1. Enable the on-demands scans page 
    Feature.enable(:dast_view_scans)
  2. Visit any project's on-demand scans page such as http://127.0.0.1:3000/groups/flightjs/-/on_demand_scans

If you have run on-demand scans before, they should be visible here.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #341364 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports