Skip to content

Draft: Remove expires_in key

Reuben Pereira requested to merge 341248-fix-display-time into master

What does this MR do and why?

Describe in detail what your merge request does and why.

GroupMembersController#update and ProjectMembersController#update return an expires_in key. The value of the expires_in key uses distance_of_time_in_words_to_now which does not respect the User#time_display_relative setting added in #14560 (closed). So, we planned on changing it to use time_ago_with_tooltip. But the expires_in key doesn't seem to be used. So this MR removes the expires_in key.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

The before and after screenshots are the same, so I've not included both.

Project members table Group members table
As a maintainer/owner Screenshot_from_2021-11-09_20-19-12 Screenshot_from_2021-11-09_20-29-26
As a developer Screenshot_2021-11-09_at_20-42-32_Members___H5bp_Html5_Boilerplate Screenshot_2021-11-09_at_20-44-16_Group_members___H5bp

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

For group members table:

  1. In your GDK, go to any group.
  2. Go to Group Information > Members.
  3. Change the expiry date of any member.

For project members table:

  1. In your GDK, go to any project.
  2. Go to Project Information > Members.
  3. Change the expiry date of any member.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #341248 (closed)

Edited by Reuben Pereira

Merge request reports

Loading