Skip to content

Decouple group's storage table from feature flag

What does this MR do and why?

It update's the storage table to show a unified view regardless of additionalRepoStorageByNamespace feature flag.

Previously the component had 2 views: the default one and an extended one that's controlled by a feature flag, now we want the component to have a unified view.

By unifying the view we'll be losing the "excess storage" column, we'll iterate later to add it in a different way.

It also updates the project skeleton loader to have 5 rows instead of 20.

Screenshots or screen recordings

before after
Screen_Shot_2021-10-28_at_9.13.11_AM Screen_Shot_2021-10-28_at_9.11.17_AM
Screen_Shot_2021-11-02_at_1.06.07_PM Screen_Shot_2021-11-02_at_1.05.44_PM

How to set up and validate locally

  1. Navigate to a group (with maintainer+ role)
  2. From the left sidebar go to Settings > Usage Quotas > "Storage" tab
  3. In the rails console, disable/enable the additionalRepoStorageByNamespace feature flag and observe the storage table doesn't change
    1. Feature.enable(:additionalRepoStorageByNamespace)
    2. Feature.disable(:additionalRepoStorageByNamespace)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #343542 (closed)

Edited by Ammar Alakkad

Merge request reports

Loading